zeroshade commented on code in PR #35257:
URL: https://github.com/apache/arrow/pull/35257#discussion_r1173866628
##########
go/arrow/schema_test.go:
##########
@@ -99,6 +100,9 @@ func TestMetadata(t *testing.T) {
if got, want := tc.md.String(), tc.serialize; got !=
want {
t.Fatalf("invalid stringer: got=%q, want=%q",
got, want)
}
+ if len(tc.kvs) != 0 {
+ assert.Equal(t, tc.kvs, md.ToMap())
+ }
Review Comment:
how about adding a round trip test:
create a map, construct the metadata from the map, then call `ToMap` on the
result and assert the two maps are equal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
