Dandandan commented on a change in pull request #8836:
URL: https://github.com/apache/arrow/pull/8836#discussion_r536822218
##########
File path: rust/datafusion/src/physical_plan/udaf.rs
##########
@@ -64,6 +64,12 @@ impl Debug for AggregateUDF {
}
}
+impl PartialEq for AggregateUDF {
Review comment:
I am wondering, is this the `PartialEq` implementation we always want,
or just for this purpose? Otherwise it might be better to create a normal
function outside the PartialEq for it? Or do we need it now for a map/set
somewhere?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
