yyang52 commented on issue #35287:
URL: https://github.com/apache/arrow/issues/35287#issuecomment-1518935434
> Personally I'm +1 for this, but please not break original interface a lot,
maybe just change it firstly:
>
> ```c++
> std::unique_ptr<Codec> MakeGZipCodec(int compression_level,
GZipFormat::type format) {
> return std::make_unique<GZipCodec>(compression_level, format);
> }
> ```
>
> And use `MakeGZipCodec` in `src/arrow/util/compression_internal.h`
firstly. Later we can extend it. Do you think this is ok?
Yes we would definitely not break the original interface. Change
`MakeGZipCodec` is also what I want to do first! The only thing I need to
double confirm is that since we want to pass the argument from user level to
the function `MakeGZipCodec`, we may need to add another property similar to
`compression_level` in parquet writer and pass it down to the
`compression_internal` right? Then user can set the `window_bits` when creating
the parquet writer :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
