comphead commented on PR #6065: URL: https://github.com/apache/arrow-datafusion/pull/6065#issuecomment-1519174734
Thanks folks for the feedback @mingmwang this change was tested before you PR #6003 merged and only for q32. I will retest the latest codebase soon with other benchmarks. @ozankabak mutating by dereferencing sounds good to me, I will test it out @yahoNanJing I'm not getting your part, are you saying 2 iterations each doing the operation is the faster than 1 iteration doing 2 ops every iteration? I will retest it soon, and share results. If there is still no perf benefit after #6003 I will close the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
