jiangzhx commented on PR #6088: URL: https://github.com/apache/arrow-datafusion/pull/6088#issuecomment-1519601265
> My idea is mainly based on these two test cases and what they cover. 1. [group_by_date_trunc](https://github.com/apache/arrow-datafusion/blob/main/datafusion/core/tests/sql/group_by.rs#L648) based on the method name, is to test date_trunc. I think we can use an existing test data and move to sqllogictests 3. [group_by_dictionary](https://github.com/apache/arrow-datafusion/blob/main/datafusion/core/tests/sql/group_by.rs#L745) based on the code, is testing DictionaryArray. In my opinion, it should not be migrated to sqllogictest. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
