alamb commented on issue #2741: URL: https://github.com/apache/arrow-rs/issues/2741#issuecomment-1520283259
As part of https://github.com/apache/arrow-datafusion/pull/6098 I found this ticket. It turns out DataFusion has these functions implemented: https://github.com/apache/arrow-datafusion/blob/655f2a84d86a45267ecdfde1860d3748309f270f/datafusion/physical-expr/src/expressions/binary/kernels.rs#L93-L239 Thus I think it would be fairly straightforward to implement shl and shr in arrow-rs by using the DataFusion implementations and following the example of the existing kernels in https://docs.rs/arrow/latest/arrow/compute/kernels/bitwise/fn.bitwise_or.html The tricky bit will be to cast the arguments to u32 (rather than use the same primitive type) Marking this is a good first issue as the patterns are relatively set -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
