zeroshade commented on code in PR #35303:
URL: https://github.com/apache/arrow/pull/35303#discussion_r1175400530
##########
go/parquet/pqarrow/schema.go:
##########
@@ -388,7 +388,7 @@ func fieldToNode(name string, field arrow.Field, props
*parquet.WriterProperties
}
return schema.MapOf(field.Name, keyNode, valueNode,
repFromNullable(field.Nullable), -1)
default:
- return nil, xerrors.New("not implemented yet")
+ return nil, xerrors.Errorf("support for %v not implemented
yet", field.Type.ID())
Review Comment:
probably makes more sense to just do `field.Type` instead of
`field.Type.ID()` which would be more generic (it would give "MAP" instead of
"Map<string, int>" etc....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
