wjones127 commented on PR #35298: URL: https://github.com/apache/arrow/pull/35298#issuecomment-1520357836
There's a few different changes here: 1. Preserve nullability of map values fields. I'm +1 on this. I recently fixed this for the C Data Interface https://github.com/apache/arrow/pull/35013/files 2. Preserve nullability of map keys field. I'm +0.1 on this. It's not supposed to be nullable. However I suppose it's possible for the child to have a null bit map, so maybe it's better to take care of that in the `ValidateFull` method? 3. Preserve metadata of key and value fields. I'm +0.1. Seems fine but I'm not sure about the use case. 4. Preserve field names of Map subfields. I'm -0.7 on this. The spec dictates they should be certain names, and I don't see good reason to let them deviate from this much. Right now we **don't** preserve them in the C Data Interface. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
