lidavidm commented on code in PR #34873:
URL: https://github.com/apache/arrow/pull/34873#discussion_r1175852852
##########
java/vector/src/main/java/org/apache/arrow/vector/ipc/ArrowWriter.java:
##########
@@ -53,6 +53,8 @@ public abstract class ArrowWriter implements AutoCloseable {
protected static final Logger LOGGER =
LoggerFactory.getLogger(ArrowWriter.class);
+ protected static final int compressionLevel = 3;
Review Comment:
And this should be clearly named DEFAULT_COMPRESSION_LEVEL
##########
java/vector/src/main/java/org/apache/arrow/vector/ipc/ArrowWriter.java:
##########
@@ -53,6 +53,8 @@ public abstract class ArrowWriter implements AutoCloseable {
protected static final Logger LOGGER =
LoggerFactory.getLogger(ArrowWriter.class);
+ protected static final int compressionLevel = 3;
Review Comment:
Constants should use UPPER_SNAKE_CASE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
