wgtmac commented on code in PR #34873:
URL: https://github.com/apache/arrow/pull/34873#discussion_r1175926144


##########
java/vector/src/main/java/org/apache/arrow/vector/ipc/ArrowWriter.java:
##########
@@ -53,6 +53,8 @@ public abstract class ArrowWriter implements AutoCloseable {
 
   protected static final Logger LOGGER = 
LoggerFactory.getLogger(ArrowWriter.class);
 
+  protected static final int compressionLevel = 3;

Review Comment:
   The default level is tricky here:
   - LZ4 default level is 1 with range from 1 to 9
   - ZSTD default level is 3 with range from 1 to 22 (also negative levels -1 
to -5 are supported)
   
   There is a [discussion](https://github.com/apache/arrow/issues/35287) on the 
C++ side to add support of `Codec::Options`. Would it be good to do similar 
things on the Java side so we can accommodate different default levels per 
codec?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to