nealrichardson commented on code in PR #35147:
URL: https://github.com/apache/arrow/pull/35147#discussion_r1175945751
##########
r/configure:
##########
@@ -252,6 +252,10 @@ echo "#include $PKG_TEST_HEADER" | ${TEST_CMD} >/dev/null
2>&1
if [ $? -eq 0 ]; then
# Check for features
+ if [ "$LIB_DIR" = "" ]; then
+ # In case LIB_DIR wasn't previously set, infer from PKG_DIRS
+ LIB_DIR=`echo $PKG_DIRS | sed -e 's/^-L//'`
+ fi
Review Comment:
@kou is this possibly relevant? `PKG_LIBS` and `PKG_DIRS` seem to be set
correctly but for some reason `LIB_DIR` isn't.
```diff
diff --git a/r/configure b/r/configure
index 65528bdc38..8e130c53b4 100755
--- a/r/configure
+++ b/r/configure
@@ -110,7 +110,7 @@ else
PKG_CFLAGS="$PKGCONFIG_CFLAGS $PKG_CFLAGS"
PKG_LIBS="${PKGCONFIG_LIBS}"
PKG_DIRS="${PKGCONFIG_DIRS}"
- LIB_DIR=${FOUND_LIB_DIR}
+ LIB_DIR="${FOUND_LIB_DIR}"
# Check for version mismatch
PC_LIB_VERSION=`pkg-config --modversion arrow`
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
