yyang52 commented on issue #35287:
URL: https://github.com/apache/arrow/issues/35287#issuecomment-1521460475
When building `parquet::WriterProperties`, there could be 2 design options:
one is to pass compression parameters separately (as the current
implementation, with more properties to be added) and make CodecOptions
internally, for example:
```c++
std::shared_ptr<parquet::WriterProperties> props =
builder.compression(parquet::Compression::GZIP)
->compression_level(9)
->set_gzip_format(parquet::GZipFormat::DEFLATE)
->gzip_window_bits(12)
->build();
```
Another is to let the user create a CodecOption and pass the option to the
builder directly:
```
CodecOption opt;
opt.compression_level = 9;
opt.window_bits = 12;
std::shared_ptr<parquet::WriterProperties> props =
builder.compression(parquet::Compression::GZIP)
->codec_option(opt)
->build();
```
Which one do you prefer? Thanks! @kou @wgtmac @mapleFU
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
