wgtmac commented on code in PR #35298:
URL: https://github.com/apache/arrow/pull/35298#discussion_r1176459073
##########
cpp/src/arrow/ipc/metadata_internal.cc:
##########
@@ -367,8 +367,8 @@ Status ConcreteTypeFromFlatbuffer(flatbuf::Type type, const
void* type_data,
return Status::Invalid("Map's keys must be non-nullable");
} else {
auto map = static_cast<const flatbuf::Map*>(type_data);
- *out = std::make_shared<MapType>(children[0]->type()->field(0)->type(),
- children[0]->type()->field(1)->type(),
+ *out =
std::make_shared<MapType>(children[0]->type()->field(0)->WithName("key"),
Review Comment:
A lot of CI checks failed:
```
Run pip install -e dev/archery[docker]
Obtaining file:///home/runner/work/arrow/arrow/dev/archery
Installing build dependencies: started
Installing build dependencies: finished with status 'error'
error: subprocess-exited-with-error
× pip subprocess to install build dependencies did not run successfully.
│ exit code: 1
╰─> [2 lines of output]
ERROR: Could not find a version that satisfies the requirement
setuptools>=40.8.0 (from versions: none)
ERROR: No matching distribution found for setuptools>=40.8.0
[end of output]
note: This error originates from a subprocess, and is likely not a problem
with pip.
error: subprocess-exited-with-error
× pip subprocess to install build dependencies did not run successfully.
│ exit code: 1
╰─> See above for output.
note: This error originates from a subprocess, and is likely not a problem
with pip.
Error: Process completed with exit code 1.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
