viirya commented on PR #6103: URL: https://github.com/apache/arrow-datafusion/pull/6103#issuecomment-1522268593
> The one thing I didn't see was tests (other than the change to the tpch.slt test) > I think there is value adding additional tests so that if we break this code accidentally in a future refactor the tests will fail too. Yea, I have unit test for the kernel in the patch for arrow-rs. Let me also add it here too. > Could you please file / add a link to the upstream arrow-rs ticket that tracks adding multiply_fixed_point_dyn or whatever else is needed to remove the copy in DataFusion? Yea, not filing a arrow-rs ticket yet, just first wanted to verify it pass all DataFusion existing tests. I will file one and link it here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
