alamb commented on code in PR #6106: URL: https://github.com/apache/arrow-datafusion/pull/6106#discussion_r1177729222
########## datafusion/execution/src/runtime_env.rs: ########## @@ -33,6 +33,15 @@ use url::Url; #[derive(Clone)] /// Execution runtime environment. +/// +/// A [`RuntimeEnv`] can be created from a [`RuntimeConfig`] and +/// stores state to be shared across multiple sessions. In most Review Comment: This is a good point -- by default a `SessionContext` creates a new instance of `RuntimeEnv` -- however that means any limits are not enforced across queries. I think this comment was trying to say if you want limits enforced across multiple session contexts you need to use the same RuntimeEnv I have tried to clarify this in 0bbf68718e -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
