zeroshade commented on code in PR #35338: URL: https://github.com/apache/arrow/pull/35338#discussion_r1177987580
########## go/go.mod: ########## @@ -16,7 +16,7 @@ module github.com/apache/arrow/go/v12 -go 1.18 +go 1.20 Review Comment: the version in the go.mod file isn't a minimum but a "recommended" version. The problem is that you cannot use anything in the module that is only introduced in a version *after* the one specified in the go.mod. Since I'm using `unsafe.StringData` which was only introduced in go1.20, I need to bump the go.mod version in order to use it. Otherwise it won't compile, even though it's behind a build constraint. That said, this still won't prevent earlier versions of go from compiling the module, it'll just print an advisory note if there's a compile error saying that the module "recommends" go1.20 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
