WillAyd commented on code in PR #587:
URL: https://github.com/apache/arrow-adbc/pull/587#discussion_r1178013337
##########
c/driver/common/utils.c:
##########
@@ -28,7 +28,7 @@
static size_t kErrorBufferSize = 256;
static char kErrorPrefix[] = "[SQLite] ";
-void ReleaseError(struct AdbcError* error) {
+static void ReleaseError(struct AdbcError* error) {
Review Comment:
Don't think it's an immediate issue but since these aren't exposed in the
header I think safer to keep them scoped to only usable within the TU
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]