zeroshade commented on code in PR #586:
URL: https://github.com/apache/arrow-adbc/pull/586#discussion_r1178107124
##########
c/validation/adbc_validation.cc:
##########
@@ -53,6 +54,15 @@ namespace {
} while (false)
} // namespace
+/// case insensitive string compare
+bool iequals(std::string s1, std::string s2) {
Review Comment:
it's not using string_view or a const string because i'm actually modifying
the strings here. I'll change this to do the comparison without modifying the
strings and have it use string_view
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
