henrymai opened a new pull request, #35353:
URL: https://github.com/apache/arrow/pull/35353
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's
Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing
Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor
PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes).
Could you open an issue for this pull request on GitHub?
https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the
[Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.)
of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
Fix the UnionListWriter template to correctly generate the methods to allow
writing to the types that were failing before.
Without the fix, the new test added would have the following kinds of
failures:
TestListVector.testWriterGetTimestampMilliTZField:913 ? IllegalArgument
You tried to write a TimeStampMilliTZ type when you are using a ValueWriter of
type UnionListWriter.
Since this fix is a generalized change, it fixes the same problem with
writing for a bunch of other types like fixedSizeBinary and duration.
Here is also a diff (manually hand minimized diff) of the old generated
UnionListWriter vs the new one:
https://gist.github.com/henrymai/03b0f5a4165cd9822aa797c89bbd74e9
### What changes are included in this PR?
- UnionListWriter template generalization and fix.
- Additional tests to verify that this is fixed.
### Are these changes tested?
Yes, added unit tests and they pass.
### Are there any user-facing changes?
Yes, users will now be able to write to more child types for lists.
<!--
If there are any breaking changes to public APIs, please uncomment the line
below and explain which changes are breaking.
-->
<!-- **This PR includes breaking changes to public APIs.** -->
<!--
Please uncomment the line below (and provide explanation) if the changes fix
either (a) a security vulnerability, (b) a bug that caused incorrect or invalid
data to be produced, or (c) a bug that causes a crash (even when the API
contract is upheld). We use this to highlight fixes to issues that may affect
users without their knowledge. For this reason, fixing bugs that cause errors
don't count, since those are usually obvious.
-->
<!-- **This PR contains a "Critical Fix".** -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
