icexelloss commented on PR #34912: URL: https://github.com/apache/arrow/pull/34912#issuecomment-1525956048
@westonpace I addressed all the comments I think. For skip_nulls=false, it's actually non-trivial to support and I ended up adding three more flags (first_is_null, last_is_null, has_any_values) to support this. Please take look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
