jackkleeman opened a new pull request, #6146: URL: https://github.com/apache/arrow-datafusion/pull/6146
It should be possible to compare numeric types to uint64 literals. Currently for anything above the int64 max, it will become a float or a decimal128 depending on config. The float conversion is lossy, and the decimal type is currently not comparable with uint64, so both of these are problematic. # Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> Closes #6145. # Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> Yes # Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> Potentially this will affect how some queries are interpreted, where int literals greater than int64-max are provided. <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
