lidavidm commented on code in PR #587:
URL: https://github.com/apache/arrow-adbc/pull/587#discussion_r1179847811
##########
c/driver/common/utils.c:
##########
@@ -138,11 +138,11 @@ int StringBuilderAppend(struct StringBuilder* builder,
const char* fmt, ...) {
va_end(argptr);
if (n < 0) {
- return -1;
+ return errno;
Review Comment:
From man page, vsnprintf won't set errno so we should return our own value
(EIO?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
