tustvold commented on code in PR #4148:
URL: https://github.com/apache/arrow-rs/pull/4148#discussion_r1180107023


##########
arrow-arith/src/bitwise.rs:
##########
@@ -143,6 +177,24 @@ mod tests {
         Ok(())
     }
 
+    #[test]

Review Comment:
   Is it worth adding a test of what happens if you shift by more than the 
number of bits?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to