tustvold commented on code in PR #4156:
URL: https://github.com/apache/arrow-rs/pull/4156#discussion_r1180699150
##########
parquet/src/util/io.rs:
##########
@@ -112,9 +109,6 @@ impl<R: ParquetReader> FileSource<R> {
impl<R: ParquetReader> Read for FileSource<R> {
fn read(&mut self, buf: &mut [u8]) -> Result<usize> {
- let bytes_to_read = cmp::min(buf.len(), (self.end - self.start) as
usize);
- let buf = &mut buf[0..bytes_to_read];
Review Comment:
This could actually benefit performance, as it will avoid artificially
truncating the input buffer, causing it to not skip the FileSource buffer when
it could
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
