wgtmac commented on code in PR #35351:
URL: https://github.com/apache/arrow/pull/35351#discussion_r1180931663
##########
cpp/src/parquet/metadata.cc:
##########
@@ -1684,6 +1702,17 @@ class
RowGroupMetaDataBuilder::RowGroupMetaDataBuilderImpl {
total_compressed_size += column_builders_[i]->total_compressed_size();
}
+ const auto& sorting_columns = properties_->sorting_columns();
+ if (!sorting_columns.empty()) {
+ std::vector<format::SortingColumn>
thrift_sorting_columns(sorting_columns.size());
Review Comment:
What about adding the bi-directional thrift conversion in a single place as
here:
https://github.com/apache/arrow/blob/main/cpp/src/parquet/thrift_internal.h#L79-L101
? That would be consistent with others.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
