rtpsw commented on PR #34392:
URL: https://github.com/apache/arrow/pull/34392#issuecomment-1529445810

   I investigated [the AMD Conda job's 
behavior](https://github.com/apache/arrow/pull/34392#issuecomment-1519077885) 
and I have a plausible explanation. The debug-messages were collected afresh 
for each test iteration, so the debug-messages shown were those for the most 
recent iteration. However, the `AssertTablesEqual` failure messages was 
collected for an earlier iteration, because it was collected using `FAIL()`, 
which (because, e.g., no exception was generated) the as-of-join-test callers 
up the stack ignored and just continued running until gtest captured the 
failure. Given this, the debug-messages and the failure message were unrelated, 
so there is nothing for us to worry about here.
   
   To avoid this confusion in the future, I fixed the test-iteration code to 
break on failure.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to