jorisvandenbossche commented on PR #34769: URL: https://github.com/apache/arrow/pull/34769#issuecomment-1531113369
Another question: `groupby_test.cc`, is that just testing the helper interface (and the actual hash aggregation tests are living elsewhere), or is that useful to keep? I was first planning to just move the helper defining/executing the Declaration to `groupby_test.cc` to keep it running without exposing the helper function. But if that's not needed, I can just remove the file altogether (I see there are quite some tests involving grouped aggregations in `plan_test.cc`) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
