jhorstmann commented on a change in pull request #8842:
URL: https://github.com/apache/arrow/pull/8842#discussion_r537682366
##########
File path: rust/arrow/src/compute/kernels/sort.rs
##########
@@ -222,6 +220,72 @@ impl Default for SortOptions {
}
}
+/// Sort primitive values
+fn sort_boolean(
+ values: &ArrayRef,
+ value_indices: Vec<u32>,
+ null_indices: Vec<u32>,
+ nan_indices: Vec<u32>,
Review comment:
This parameter and the nan handling below (`nans`, `nans_len`,
`partial_cmp` instead of `cmp`) could be removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
