icexelloss commented on PR #34392: URL: https://github.com/apache/arrow/pull/34392#issuecomment-1532045368
Thanks @rtpsw , some follow up questions: > The as-of-join node mishandled the MemoStore maintenance, Can you give a bit more details on what about MemoStore maintenance is not handles correctly? You can put code in the PR too if that is easier to align with the code. It's has been a while since I looked at future asof code so a refresher is appreciated. > The as-of-join node used cached hashes, instead of computing new ones, for the key columns of a new batch. Can you remind me why do we cache the hash in the first place. What is the case that we want to hash the same batch more than once? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
