crepererum commented on code in PR #6138:
URL: https://github.com/apache/arrow-datafusion/pull/6138#discussion_r1183856045
##########
datafusion/core/src/physical_plan/planner.rs:
##########
@@ -929,10 +972,11 @@ impl DefaultPhysicalPlanner {
}
// All equi-join keys are columns now, create physical
join plan
+ let mut left_right =
self.create_initial_plan_multi([left.as_ref(), right.as_ref()],
session_state).await?;
Review Comment:
I don't agree w/ on this one. Fundamentally broken stuff can panic, that's a
common pattern in Rust. Errors should only be used where it makes sense. Esp.
most errors don't even carry enough information for a user to be meaningful.
Anyways, I'm not gonna die on that hill. Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
