alamb opened a new pull request, #6206: URL: https://github.com/apache/arrow-datafusion/pull/6206
I am trying to collect some feedback on this approach before pushing along with it # Which issue does this PR close? Closes https://github.com/apache/arrow-datafusion/issues/3419 # Rationale for this change Every time I see the type coercion and binary.rs I am saddened -- it is overly complicated for what it is doing (which is already complicated). Since I spent a while this morning loading in the context into my head to review https://github.com/apache/arrow-datafusion/pull/6196 and related code, I figured I would start trying to clean this up. # What changes are included in this PR? 1. Introduce a structure `Coercion` to represent what coercion is needed for given argument operands and operator # Are these changes tested? Existing tests # Are there any user-facing changes? As I have it now, there is no user facing API change, but I would like to press on and remove the old API eventually -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
