felipecrv commented on code in PR #35149:
URL: https://github.com/apache/arrow/pull/35149#discussion_r1183949984
##########
cpp/src/arrow/array/data.h:
##########
@@ -434,16 +455,36 @@ struct ARROW_EXPORT ArraySpan {
inline bool IsValid(int64_t i) const {
if (this->buffers[0].data != NULLPTR) {
return bit_util::GetBit(this->buffers[0].data, i + this->offset);
+ }
+ const auto type = this->type->id();
+ if (type == Type::SPARSE_UNION) {
+ return !IsNullSparseUnion(i);
+ } else if (type == Type::DENSE_UNION) {
+ return !IsNullDenseUnion(i);
+ } else if (type == Type::RUN_END_ENCODED) {
+ return !IsNullRunEndEncoded(i);
+ }
+ return this->null_count != this->length;
+ }
+
+ template <typename ArrowType>
+ inline bool IsNullFast(int64_t i) const {
+ return !IsValidFast<ArrowType>(i);
+ }
+
+ template <typename ArrowType>
+ inline bool IsValidFast(int64_t i) const {
+ if constexpr (ArrowType::type_id == Type::NA) {
Review Comment:
To be more clear: the body of these member functions in the `.cc` file,
where `logging.h` can be used, contains runtime checks.
```cpp
} else if constexpr (ArrowType::type_id == Type::SPARSE_UNION) {
return !IsNullSparseUnion(i);
} else if constexpr (ArrowType::type_id == Type::DENSE_UNION) {
return !IsNullDenseUnion(i);
} else if constexpr (ArrowType::type_id == Type::RUN_END_ENCODED) {
return !IsNullRunEndEncoded(i);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
