tz70s commented on code in PR #6202:
URL: https://github.com/apache/arrow-datafusion/pull/6202#discussion_r1184510583
##########
datafusion/core/src/physical_plan/file_format/mod.rs:
##########
@@ -234,6 +234,39 @@ impl FileScanConfig {
}
}
+impl Display for FileScanConfig {
+ fn fmt(&self, f: &mut Formatter) -> FmtResult {
+ let (schema, _, ordering) = self.project();
+
+ let output_ordering_str = ordering
+ .map(|v| make_output_ordering_string(&v))
+ .unwrap_or(String::from("[]"));
+
+ write!(
+ f,
+ "file_groups={}, projection={}, limit={:?}, output_ordering={}",
+ FileGroupsDisplay(&self.file_groups),
+ ProjectSchemaDisplay(&schema),
+ self.limit,
+ output_ordering_str
+ )
+ }
+}
+
+fn make_output_ordering_string(ordering: &[PhysicalSortExpr]) -> String {
Review Comment:
Thanks I made the change with a wrapper.
However, I kept the imperative style instead of using join as I think it
will do the actual copy, though I don't think performance matters that much for
such path though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
