jackwener commented on code in PR #6221:
URL: https://github.com/apache/arrow-datafusion/pull/6221#discussion_r1184608466


##########
datafusion/core/src/physical_plan/planner.rs:
##########
@@ -2053,10 +2053,7 @@ mod tests {
         ];
         for case in cases {
             let logical_plan = 
test_csv_scan().await?.project(vec![case.clone()]);
-            let message = format!(
-                "Expression {case:?} expected to error due to impossible 
coercion"
-            );
-            assert!(logical_plan.is_err(), "{}", message);

Review Comment:
   Type checking is done in the `Type coercion analyzer rule` rather than 
directly in the build
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to