wgtmac commented on code in PR #35368:
URL: https://github.com/apache/arrow/pull/35368#discussion_r1184714290
##########
cpp/src/parquet/column_reader.h:
##########
@@ -152,6 +152,10 @@ class PARQUET_EXPORT PageReader {
// @returns: shared_ptr<Page>(nullptr) on EOS, std::shared_ptr<Page>
// containing new Page otherwise
+ //
+ // In SerializedPageReader, it reuses same decryption buffer and
Review Comment:
This is implementation detail, should we expose it to the doc string?
##########
cpp/src/parquet/column_reader.cc:
##########
@@ -275,6 +275,9 @@ class SerializedPageReader : public PageReader {
}
// Implement the PageReader interface
+ //
+ // SerializedPageReader reuse same decryption buffer and decompression
buffer,
Review Comment:
```suggestion
// SerializedPageReader reuses same decryption buffer and decompression
buffer,
```
##########
cpp/src/parquet/column_reader.cc:
##########
@@ -275,6 +275,9 @@ class SerializedPageReader : public PageReader {
}
// Implement the PageReader interface
+ //
+ // SerializedPageReader reuse same decryption buffer and decompression
buffer,
Review Comment:
Should we make it clear when and which buffer will be reused? For example,
- If compression is enabled, decompression_buffer_ will be reused.
- If compression is not enabled but encryption is enabled,
decryption_buffer_ will be reused.
- Neither encryption nor compression is enabled, the buffer is obtained
directly from reading the stream.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
