sjperkins commented on code in PR #35430:
URL: https://github.com/apache/arrow/pull/35430#discussion_r1184737729
##########
ci/vcpkg/ports.patch:
##########
@@ -49,18 +49,5 @@ index 0000000000..a57ce0c22f
+ return v & ~(mask << (8 * n));
+-#endif
+ }
-+
++
+ static inline bool LeftShiftOverflows(uint8_t value, uint32_t shift) {
-diff --git a/scripts/cmake/vcpkg_find_acquire_program.cmake
b/scripts/cmake/vcpkg_find_acquire_program.cmake
-index 4611af6..d11936f 100644
---- a/scripts/cmake/vcpkg_find_acquire_program.cmake
-+++ b/scripts/cmake/vcpkg_find_acquire_program.cmake
-@@ -239,7 +239,7 @@ function(vcpkg_find_acquire_program program)
- set(paths_to_search
"${DOWNLOADS}/tools/python/${tool_subdirectory}")
- vcpkg_list(SET post_install_command "${CMAKE_COMMAND}" -E rm
python310._pth)
- else()
-- set(program_name python3)
-+ set(program_name python)
- set(brew_package_name "python")
- set(apt_package_name "python3")
- endif()
Review Comment:
The above patch no longer cleanly applies due to
https://github.com/microsoft/vcpkg/pull/30780.
Having removed it, the following local builds succeed.
```bash
$ ARCH=amd64 PYTHON=3.10 archery docker run python-wheel-manylinux-2014
$ ARCH=amd64 PYTHON=3.10 archery docker run python-wheel-manylinux-2-28
```
However, it's probably worth running the entire suite to check if everything
is OK
##########
.env:
##########
@@ -92,12 +92,7 @@ DEVTOOLSET_VERSION=
# Used through docker-compose.yml and serves as the default version for the
# ci/scripts/install_vcpkg.sh script. Prefer to use short SHAs to keep the
# docker tags more readable.
-#
-# Please also update the crossbow configuration in order to keep the github
-# actions cache up to date for the macOS wheels:
-#
https://github.com/ursacomputing/crossbow/blob/master/.github/workflows/cache_vcpkg.yml
-# TODO: Update to an official release tag
https://github.com/apache/arrow/issues/35099
Review Comment:
Removed due to suggestion here:
https://github.com/apache/arrow/pull/34818#discussion_r1184321238
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
