benibus commented on code in PR #35280:
URL: https://github.com/apache/arrow/pull/35280#discussion_r1185301484
##########
cpp/src/arrow/compute/kernels/vector_array_sort.cc:
##########
@@ -173,6 +173,116 @@ class ArrayCompareSorter {
}
};
+template <>
+class ArrayCompareSorter<DictionaryType> {
+ public:
+ Result<NullPartitionResult> operator()(uint64_t* indices_begin, uint64_t*
indices_end,
+ const Array& array, int64_t offset,
+ const ArraySortOptions& options,
+ ExecContext* ctx) {
+ const auto& dict_array = checked_cast<const DictionaryArray&>(array);
+ // TODO: These methods should probably return a const&? They seem capable.
Review Comment:
https://github.com/apache/arrow/issues/35437 (also included in the TODO)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
