alamb opened a new pull request, #6235:
URL: https://github.com/apache/arrow-datafusion/pull/6235

   # Which issue does this PR close?
   
   Part of porting tests to sqllogic test 
https://github.com/apache/arrow-datafusion/pull/6234
   
   # Rationale for this change
   
   Some tests in `window.rs` programmatically create "infinite" external 
tables. I want to port them to SQL and thus I need to be able to do the same 
thing programatically
   
   # What changes are included in this PR?
   
   Add support for `('infinite_source', 'true1')` in `CREATE EXTERNAL TABLE`:
   
   ```sql
   CREATE external table t ...
   OPTIONS('infinite_source' 'true')
   LOCATION 'tests/data/empty.csv';
   ```
   
   Add a `infinite_source=true` in the explain plan (which is super easy after 
https://github.com/apache/arrow-datafusion/pull/6202 from @tz70s ❤️ )
   
   
   ```
   logical_plan TableScan: t projection=[c1]
   physical_plan CsvExec: file_groups={1 group: 
[[WORKSPACE_ROOT/datafusion/core/tests/data/empty.csv]]}, projection=[c1], 
infinite_source=true, has_header=true
   ```
   
   # Are these changes tested?
   yes
   <!--
   We typically require tests for all PRs in order to:
   1. Prevent the code from being accidentally broken by subsequent changes
   2. Serve as another way to document the expected behavior of the code
   
   If tests are not included in your PR, please explain why (for example, are 
they covered by existing tests)?
   -->
   
   # Are there any user-facing changes?
   I intend this to be used for testing mostly, so I didn't add any entry to 
the user SQL guide


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to