alamb opened a new pull request, #6236: URL: https://github.com/apache/arrow-datafusion/pull/6236
Draft until https://github.com/apache/arrow-datafusion/pull/6154 is merged # Which issue does this PR close? Follow on to https://github.com/apache/arrow-datafusion/pull/6154 # Rationale for this change We had substantial back and forth on https://github.com/apache/arrow-datafusion/pull/6154 related to locking or a single batch on each insert or for the entire operation. This required two similar, but not quite the same codepaths Upon reflection, since everything is being buffered anyways, we can avoid a second mostly copy of the loop and instead just insert the batches once at the end of the stream. # What changes are included in this PR? 1. Pull state into a `struct` with names 2. Buffer batches in a separate `Vec` and then insert them all at once when the input stream is done 3. Remove the second mostly copy # Are these changes tested? covered by existing tests <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 4. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> # Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
