westonpace commented on code in PR #35347:
URL: https://github.com/apache/arrow/pull/35347#discussion_r1186547232
##########
cpp/src/arrow/compute/key_map.h:
##########
@@ -226,12 +228,12 @@ class ARROW_EXPORT SwissTable {
// ---------------------------------------------------
// * Empty bucket has value 0x80. Non-empty bucket has highest bit set to 0.
//
- uint8_t* blocks_;
+ std::shared_ptr<Buffer> blocks_;
// Array of hashes of values inserted into slots.
// Undefined if the corresponding slot is empty.
// There is 64B padding at the end.
Review Comment:
Buffer ensures that allocations are aligned (and I think, at least 64 bytes)
but I don't know if it actually guarantees padding. I think this buffer needs
to go 64 bytes past the end regardless of the size which is a slightly
different requirement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
