mapleFU commented on code in PR #35455:
URL: https://github.com/apache/arrow/pull/35455#discussion_r1186610202
##########
cpp/src/parquet/column_writer.cc:
##########
@@ -460,7 +460,11 @@ class SerializedPageWriter : public PageWriter {
ToThrift(page.definition_level_encoding()));
data_page_header.__set_repetition_level_encoding(
ToThrift(page.repetition_level_encoding()));
- data_page_header.__set_statistics(ToThrift(page.statistics()));
+
+ // Write page statistics only when page index is not enabled.
Review Comment:
Seems that this will invalidate page filter?
##########
cpp/src/parquet/column_writer.cc:
##########
@@ -479,7 +483,11 @@ class SerializedPageWriter : public PageWriter {
page.repetition_levels_byte_length());
data_page_header.__set_is_compressed(page.is_compressed());
- data_page_header.__set_statistics(ToThrift(page.statistics()));
+
+ // Write page statistics only when page index is not enabled.
Review Comment:
what if that Page Index is canceled, like all values is nan?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
