rtpsw commented on PR #35469: URL: https://github.com/apache/arrow/pull/35469#issuecomment-1537149084
This is odd. The [former build error](https://github.com/apache/arrow/pull/35469#issuecomment-1537145980) was due to `void benchmark::MemoryManager::Stop(benchmark::MemoryManager::Result&)` not overridden by `void arrow::MemoryPoolMemoryManager::Stop(benchmark::MemoryManager::Result*)` (a pointer argument mismatch to a reference argument), while the [current `AMD64 Windows 2019 C++17` CI job build error](https://github.com/apache/arrow/actions/runs/4901926429/jobs/8753471651?pr=35469) (where a reference argument is used) is due to the opposite. Apparently, the signature of `benchmark::MemoryManager::Stop` is inconsistent across platforms. I'll revert this commit and leave the fix to future work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
