ParthChonkar commented on code in PR #35476:
URL: https://github.com/apache/arrow/pull/35476#discussion_r1187562298
##########
java/vector/src/main/java/org/apache/arrow/vector/VectorSchemaRoot.java:
##########
@@ -327,10 +327,6 @@ public VectorSchemaRoot slice(int index, int length) {
Preconditions.checkArgument(index + length <= rowCount,
"index + length should <= rowCount");
- if (index == 0 && length == rowCount) {
- return this;
Review Comment:
For each vector `splitAndTransfer` will derive a new ArrowBuffer (unlike
`transfer`) for the vector's underlying buffer(s) and then transfer ownership
of those so it won't invalidate the original root. But both will point to the
same memory location.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
