candiduslynx commented on code in PR #35457:
URL: https://github.com/apache/arrow/pull/35457#discussion_r1187616418
##########
go/arrow/example_test.go:
##########
@@ -252,7 +252,7 @@ func Example_fixedSizeListArray() {
// NullN() = 2
// Len() = 5
// Type() = fixed_size_list<item: int64>[3]
- // List = [[0 1 2] (null) [3 4 5] [6 7 8] (null)]
+ // List = [[0 1 2] (null) [-1 -1 -1] [3 4 5] (null)]
Review Comment:
@zeroshade I've extracted the change into
https://github.com/apache/arrow/pull/35481.
I'll update the code after that one is merged.
##########
go/arrow/array/fixed_size_list.go:
##########
@@ -207,6 +207,10 @@ func (b *FixedSizeListBuilder) Append(v bool) {
func (b *FixedSizeListBuilder) AppendNull() {
b.Reserve(1)
b.unsafeAppendBoolToBitmap(false)
+ // require to append this due to value indexes
+ for i := int32(0); i < b.n; i++ {
+ b.values.AppendNull()
+ }
Review Comment:
@zeroshade I've extracted the change into
https://github.com/apache/arrow/pull/35481.
I'll update the code after that one is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
