candiduslynx commented on code in PR #35457:
URL: https://github.com/apache/arrow/pull/35457#discussion_r1187636135
##########
go/internal/types/extension_types.go:
##########
@@ -111,43 +126,18 @@ func (b *UUIDBuilder) UnmarshalJSON(data []byte) error {
}
if delim, ok := t.(json.Delim); !ok || delim != '[' {
- return fmt.Errorf("fixed size binary builder must unpack from
json array, found %s", delim)
+ return fmt.Errorf("uuid builder must unpack from json array,
found %s", delim)
}
return b.Unmarshal(dec)
}
-func (b *UUIDBuilder) AppendValueFromString(s string) error {
- if s == array.NullValueStr {
- b.AppendNull()
- return nil
- }
- u, err := uuid.Parse(s)
- if err != nil {
- return fmt.Errorf("%w: invalid uuid: %v", arrow.ErrInvalid, err)
- }
- b.Append(u)
- return nil
-}
Review Comment:
Fixed in 3643d9b61176744c84e0061bc2e99815f659e3db
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
