kou commented on code in PR #35484: URL: https://github.com/apache/arrow/pull/35484#discussion_r1187993559
########## python/pyarrow/src/arrow/python/platform.h: ########## @@ -32,5 +32,10 @@ #if _MSC_VER >= 1900 #undef timezone #endif + +// https://bugs.python.org/issue36020 +#if _MSC_VER >= 1500 +#undef snprintf +#endif Review Comment: It seems that the macro was removed by https://github.com/python/cpython/commit/e822e37946f27c09953bb5733acf3b07c2db690f . How about the following? ```cpp #ifdef snprintf #undef snprintf #endif ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
