paleolimbot commented on code in PR #189:
URL: https://github.com/apache/arrow-nanoarrow/pull/189#discussion_r1188565868
##########
CMakeLists.txt:
##########
@@ -41,6 +41,12 @@ else()
set(NANOARROW_NAMESPACE_DEFINE "// #define NANOARROW_NAMESPACE
YourNamespaceHere")
endif()
+if (CMAKE_BUILD_TYPE STREQUAL "Debug")
+ set(NANOARROW_DEBUG_DEFINE "#define NANOARROW_DEBUG 1")
+else()
+ set(NANOARROW_DEBUG_DEFINE "// #define NANOARROW_DEBUG 1")
+endif()
Review Comment:
Thanks for this...I like the `target_compile_definitions()` solution better.
Debug mode should probably never be hard-coded in a header and should probably
always be invoked via a compiler define.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
