[GitHub] [arrow] Dandandan commented on pull request #8863: ARROW-10837: [Rust][DataFusion] Use `Vec` for hash keys

[GitBox]

Dandandan commented on pull request #8863:
URL: https://github.com/apache/arrow/pull/8863#issuecomment-740809969


   @jorgecarleitao 
   
   Just extended the change for hash aggregates as well.
   
   Turns out, a good speedup as well for hash aggregate queries!
   
   [This version]
   ```
   Query 1 iteration 0 took 871 ms
   Query 1 iteration 1 took 866 ms
   Query 1 iteration 2 took 869 ms
   Query 1 iteration 3 took 869 ms
   Query 1 iteration 4 took 867 ms
   Query 1 iteration 5 took 874 ms
   Query 1 iteration 6 took 870 ms
   Query 1 iteration 7 took 875 ms
   Query 1 iteration 8 took 871 ms
   Query 1 iteration 9 took 869 ms
   ```
   
   [Master]
   ```
   Query 1 iteration 0 took 1189 ms
   Query 1 iteration 1 took 1192 ms
   Query 1 iteration 2 took 1189 ms
   Query 1 iteration 3 took 1185 ms
   Query 1 iteration 4 took 1193 ms
   Query 1 iteration 5 took 1202 ms
   Query 1 iteration 6 took 1547 ms
   Query 1 iteration 7 took 1242 ms
   Query 1 iteration 8 took 1202 ms
   Query 1 iteration 9 took 1197 ms
   ```
   
   
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org