tustvold opened a new pull request, #4184:
URL: https://github.com/apache/arrow-rs/pull/4184
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #4047
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
Inspired by the work in #4077 I started work on a generic
`ObjectStoreBuilder`, however, this ran into a couple of challenges
* Different stores have different configuration APIs, e.g. S3 has
ClientOptions, whereas LocalFilesystem has a prefix
* Some downstreams will want to use environment variables, and some will not
* Some downstreams will want to filter config to just match those expected
by the store, others will want to error
* There are various valid ways LocalFileSystem and Memory URLs could be
interpreted
* The feature flag plumbing was extremely fiddly, the fact we separate the
different stores is a historical artifact from when they brought in different
SDKs, downstreams shouldn't need to do this
Whilst this PR does to a certain extent punt the issue onto downstreams, I
think this standardises the non-trivial URL recognition logic, whilst allowing
downstreams to make their own opinionated decision w.r.t the above.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
