jorgecarleitao commented on a change in pull request #8824:
URL: https://github.com/apache/arrow/pull/8824#discussion_r538756496



##########
File path: .github/workflows/cpp.yml
##########
@@ -21,7 +21,7 @@ on:
   push:
     paths:
       - '.github/workflows/cpp.yml'
-      - 'ci/docker/**'
+      - 'ci/docker/*cpp*'

Review comment:
       I just did a quick check to verify this, and AFAI can tell my hypothesis 
holds:
   
   ```docker-compose
   services:
     s1:
       image: t1
       build:
         context: .
         dockerfile: docker1.dockerfile
   
     s2:
       image: t2
       build:
         context: .
         dockerfile: docker2.dockerfile
   ```
   
   ```dockerfile
   # docker1.dockerfile
   FROM python:3.7.4
   
   CMD ls
   ```
   
   ```dockerfile
   # docker2.dockerfile
   FROM t1
   
   CMD ls
   ```
   
   ```bash
   docker-compose build s2
   
   Building s2
   Step 1/3 : FROM t1
   ERROR: Service 's2' failed to build : pull access denied for t1, repository 
does not exist or may require 'docker login': denied: requested access to the 
resource is denied
   ```
   
   My understanding is that docker has no idea about `docker-compose` and how 
images get built; it only knows about where images are located, via registries. 
To declare such a dependency of image builds, Docker uses Multi-stage builds. 
Furthermore, docker-compose also does not declare image dependencies, only 
service dependencies (i.e. containers, not images).
   
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to